inference: remove MAX_TYPE_DEPTH limit, rewrite tmerge #26628
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`type_too_complex` / `MAX_TYPE_DEPTH` is not well-defined (this was the last remaining usage) `_typename(a::Vararg)` does not mean what the author probably thought / intended (it is the same as ..., and thus was dead code) This limit is now handled with more surgical precision by `limit_type_size` during recursion, so we can be more permissive during iteration here.
and slow down convergence rate of Tuple and UnionAll types
|
@nanosoldier |
1 similar comment
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
vtjnash
force-pushed
the
jn/typelimits
branch
2 times, most recently
from
593af8f
to
c3ebc9e
Compare
… Int}`
While the new optimizer should handle this better,
the optimal efficient way to handle this is to make the missingness entirely disjoin:
`Union{Nothing, Tuple{Something, Int}}`
And make each `val` variable SSA, for better inference
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
great. will merge soon if no objections |
omus
added a commit
to JuliaTime/TimeZones.jl
that referenced
this pull request
Apr 14, 2018
Change as a part of: JuliaLang/julia#26628
omus
added a commit
to JuliaTime/TimeZones.jl
that referenced
this pull request
Apr 14, 2018
Change as a part of: JuliaLang/julia#26628
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These arbitrary limits don't seem necessary any more (at least for
make test), and weren't being used where they would have been needed the most (Tuple) anyways. This also tries to improve the associativity of the algorithm and slowing down the convergence, with an eye towards giving better results whenNothinggets joined into a mix of abstract types:fix #26610
close #23077