Commits on Apr 27, 2018

1. [NewOptimizer] Backport reverse affinity changes from #26778 …

   In #26778, I changed the way that the reverse affinity flag works
   in order to support node insertion during compaction. In particular,
   I had originally (for ease of implementation primarily) had that flag
   simply change which BB an inserted node belongs to (i.e. if that flag
   was set and there was a basic block boundary at the insertion site,
   the new node would belong to the previous BB). In #26778, I changed
   this to instead be a flag of whether to insert before or after a given
   instruction. As it turns out, this change is also required for correctness.
   Because domsorting can change the notion of "previous instruction" by
   moving basic blocks, we had (in rare circumstances) instructions end
   up in the wrong BB. Backporting those changes fixes that.

   

   Keno committed Apr 27, 2018
   Configuration menu

   • View commit details
   • Copy full SHA for 99016fd
   • Browse repository at this point

   Copy the full SHA

   99016fd View commit details

   Browse the repository at this point in the history