[NewOptimizer] Fix PhiC type lifting for nested try/catch #26943
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes two closely related bugs: - PhiC nodes were not participating in type refinement during SSA construction, leading to PhiC nodes that were part of a phi cycle to have too narrow a type. - PhiC nodes part of a Phi cycle did not get an appropriate upsilon node inserted during type lifting.
ararslan
added
the
compiler:optimizer
|
cc @mbauman for the broadcast failure on Win64. I don't believe this code should affect anything (since the new optimizer is still disabled). |
|
I restarted the build. For reference, the failure was: https://gist.github.com/Keno/66b50c90d32117733883d43ba952c865 |
|
Yeah, that looks like I just got the bounds computation wrong and you got an unlucky random seed. I'm working on getting better bounds now… but I might just add a bit more slop. Edit: #26950 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes two closely related bugs:
leading to PhiC nodes that were part of a phi cycle to have too narrow a type.
during type lifting.