[NewOptimizer] Make simdloop marker more robust #26985
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ararslan
added
the
compiler:optimizer
|
When you rebase on master, do bump Line 2 in bfb1c1b 2
|
Turns out getLoopID doesn't always get what setLoopID set. I submitted a patch upstream to fix that. This carries that patch.
Previously the simdloop marker was metadata on a random add instruction in the loop. This is problematic if that add instruction gets moved around or folded by an earlier optimization pass. Switching to using an explicit marker instruction. Eventually we should do something different here to address #26976. This just makes it more robust to make sure it keeps working with the new optimizer.
|
Just in case: @nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
|
Bizarrely enough only on the AArch64 build bots I am seeing: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See the individual commits for details. There's a couple regression in #26795 due to the new optimizer dropping simdloop annotations where it shouldn't. Fixing that was easy, but unfortunately, the simd loop metadata still got lost with the code generated by the new optimizer. The last commit fixes that by making the marker more robust against premature optimization. Unfortunately this exposed an LLVM bug which is fixed by the second commit. The combination of these restores SIMD loop functionality for the new optimizer.