tweak SHA1 printing #27036
tweak SHA1 printing #27036
Conversation
simonbyrne
commented
May 8, 2018
simonbyrne
commented
- Print quotes around byte string in show
- Add a print method to enable string interpolation
|
Incidentally, we should do the same with the printing of UUIDs. |
ararslan
added
the
display and printing
|
Needs a test? |
test/loading.jl
Outdated
| @@ -86,6 +86,18 @@ import UUIDs: UUID, uuid4, uuid_version | |||
| import Random: shuffle, randstring | |||
| using Test | |||
|
|
|||
| shastr = "ab"^20 | |||
| hash = SHA1(shastr) | |||
| @test hash == eval(sprint(io -> show(io, hash))) # check show method | |||
There was a problem hiding this comment.
Do you mean eval(parse(string(hash)))?
test/loading.jl
Outdated
| @@ -88,13 +88,13 @@ using Test | |||
|
|
|||
| shastr = "ab"^20 | |||
| hash = SHA1(shastr) | |||
| @test hash == eval(sprint(io -> show(io, hash))) # check show method | |||
| @test hash == eval(parse(sprint(io -> show(io, hash)))) # check show method | |||
There was a problem hiding this comment.
Isn't string(hash) equivalent to sprint(show, hash) which is equivalent to sprint(io -> show(io, hash))?
There was a problem hiding this comment.
The purpose of this PR was to make string(hash) and show(hash) different. I didn't think of using sprint(show, hash) though, good call.
There was a problem hiding this comment.
Couldn't you use repr(hash) then?
(Sorry, string is equivalent to print, and repr is equivalent to show.)
There was a problem hiding this comment.
Yes! I keep forgetting about those functions.
test/loading.jl
Outdated
| hash = SHA1(shastr) | ||
| @test hash == eval(parse(repr(hash))) # check show method | ||
| @test string(hash) == shastr | ||
| @test "check $hash" == "check $shastr" |
There was a problem hiding this comment.
The last two tests seem redundant because interpolation just calls string
There was a problem hiding this comment.
That's not the case on current master:
julia> hash = Base.SHA1("aa"^20)
SHA1(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)
julia> "check $hash"
"check SHA1(aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa)"
julia> string(hash)
"aaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa"
There was a problem hiding this comment.
What? I just looked at @code_lowered for "foo $x", and it lowers to string("foo ", x), which calls print_to_string, which calls print (not show).
What am I missing?
There was a problem hiding this comment.
The documentation of string(xs...) also says that it calls print. Something seems wrong here.
| string(hash::SHA1) = bytes2hex(hash.bytes) | ||
| print(io::IO, hash::SHA1) = print(io, string(hash)) |
There was a problem hiding this comment.
This seems suboptimal: It seems like we should have a bytes2hex(io, bytes) method that writes the hex digits to a stream rather than allocating a string. That way you can print the hex digits directly instead of allocating a string first.
There was a problem hiding this comment.
Let's get this merged and tweak for optimality in the future; issue: #27121.
1. Print quotes around byte string in show 2. Add a print method to enable string interpolation
test/loading.jl
Outdated
| @@ -86,6 +86,18 @@ import UUIDs: UUID, uuid4, uuid_version | |||
| import Random: shuffle, randstring | |||
| using Test | |||
|
|
|||
| shastr = "ab"^20 | |||
| hash = SHA1(shastr) | |||
There was a problem hiding this comment.
These variables should all be let-bound.
