Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make grisu thread-safe again #27826

Merged
merged 1 commit into from
Jun 28, 2018
Merged

Make grisu thread-safe again #27826

merged 1 commit into from
Jun 28, 2018

Conversation

simonbyrne
Copy link
Contributor

@simonbyrne simonbyrne commented Jun 27, 2018

Digit printing on the slow path was still not thread-safe after #26562, e.g. with JULIA_NUM_THREADS=4 I get errors with the following:

using Base.Threads
V = fill(2.99965547519468e17, 100)
function test_without_mutex(V)
    @threads for v in V
        y = "$v"
        @assert v == parse(Float64, y)
    end
end
test_without_mutex(V)

@simonbyrne simonbyrne requested a review from stevengj June 27, 2018 16:45
@simonbyrne simonbyrne added multithreading Base.Threads and related functionality display and printing Aesthetics and correctness of printed representations of objects. labels Jun 27, 2018
@simonbyrne simonbyrne requested a review from quinnj June 28, 2018 17:01
@quinnj quinnj merged commit 9965e7c into master Jun 28, 2018
@quinnj quinnj deleted the sb/grisu-bignum-threadsafe branch June 28, 2018 21:54
@stevengj stevengj mentioned this pull request Jun 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
display and printing Aesthetics and correctness of printed representations of objects. multithreading Base.Threads and related functionality
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants