update deprecations for init kwarg #27862
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fredrikekre
added
the
deprecation
rfourquet
reviewed
Jun 29, 2018
| @@ -1722,6 +1722,9 @@ end | |||
| @deprecate mapreduce(f, op, v0, itr) mapreduce(f, op, itr; init=v0) | |||
| @deprecate mapfoldl(f, op, v0, itr) mapfoldl(f, op, itr; init=v0) | |||
| @deprecate mapfoldr(f, op, v0, itr) mapfoldr(f, op, itr; init=v0) | |||
| # also deprecate the old deprecations | |||
| @deprecate mapreduce(f, op, v0, A; dims=dims) mapreduce(f, op, A; init = v0, dims=dims) | |||
There was a problem hiding this comment.
I think this definition overwrites the one 4 lines above, as there is no dispatch on keywords (I also made the same kind of mistake a couple of times!). While compiling julia, there is a message that mapreduce and reduce are overwriten. The problem is that now I get an error message in a package using mapreduce that dims is not defined.
There was a problem hiding this comment.
Here too:
julia> reduce(+, 0, [1,2,3])
ERROR: UndefVarError: dims not defined
Stacktrace:
[1] reduce(::Function, ::Int64, ::Array{Int64,1}) at ./deprecated.jl:54
[2] top-level scope at none:0There was a problem hiding this comment.
Hmm, is there no way to do this then? I'll have a look, sorry!
This was referenced Jun 29, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated the deprecations, and adds deprecations for the old methods for people that have already adopted the new code (it currently errors).