Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add NEWS entry for #28156: add splitpath(p) #29448

Merged
merged 1 commit into from
Oct 5, 2018

Conversation

NHDaly
Copy link
Member

@NHDaly NHDaly commented Oct 1, 2018

No description provided.

@NHDaly
Copy link
Member Author

NHDaly commented Oct 1, 2018

Something like this?

It was a bit confusing cause the NEWS.md file currently still looks like it's for the 1.0.0 launch, not v1.0.1. Should I have based it off of a different branch or something? Thanks! :)

@StefanKarpinski
Copy link
Member

Do we actually have a joinpath method that takes an array?

@NHDaly
Copy link
Member Author

NHDaly commented Oct 1, 2018

Eep! Thanks Stefan, I did that late at night and didn't actually think to check.. -_- thanks. Corrected it to joinpath(parts...), which is the description in its docstring.

I'm still about confused about whether this is the right place to make this change though. Could you comment on that? Thanks!

@StefanKarpinski
Copy link
Member

It's a bit unclear—we're going to have to figure out what the right headings for release notes are as part of our new release process. This seems fine for now; we can always rearrange later.

@NHDaly
Copy link
Member Author

NHDaly commented Oct 1, 2018

Okay cool, works for me!

In particular, I was confused because reading that file, it seems like it's still referring to the julia v1.0.0 release, even though now I guess master would be v1.0.2? Or v1.1.0 even?

AND that file looks different in both the v1.0.0 and v1.0.1 tags than it does at master:
https://github.com/JuliaLang/julia/blob/v1.0.0/NEWS.md
https://github.com/JuliaLang/julia/blob/v1.0.1/NEWS.md

So that's why i'm asking. Is the NEWS.md file on master supposed to reflect the last major/minor release, such that this PR shouldn't be attempting to merge into master, but rather into some development branch? Thanks, and sorry for the confusion! :)

@StefanKarpinski
Copy link
Member

Ah yes, this will actually only go out in Julia 1.1 since it's a new feature.

@Sacha0
Copy link
Member

Sacha0 commented Oct 1, 2018

Ah yes, this will actually only go out in Julia 1.1 since it's a new feature.

Agreed, looks like the v1.0.0 release notes should move to history, and v1.1.0 release notes should replace them, with this entry under the latter? Best!

@JeffBezanson
Copy link
Member

#29490

@NHDaly
Copy link
Member Author

NHDaly commented Oct 3, 2018

(Thanks Jeff!)

@NHDaly
Copy link
Member Author

NHDaly commented Oct 4, 2018

Okay, this is rebased.

Merge away! Thanks

@fredrikekre fredrikekre merged commit 1968b23 into JuliaLang:master Oct 5, 2018
@NHDaly NHDaly deleted the news-splitpath branch October 6, 2018 01:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants