-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add relative and absolute tolerance for rank. #29926
Conversation
Thanks for the PR! The standard names for this are |
Thanks for reviewing @StefanKarpinski. I changed the names. |
Requesting review from @andreasnoack for general linalg expertise and @stevengj because I know you were instrumental in the design of the |
As was commented in #29793, to be consistent we should also add these keywords for |
It would be easier to review them together for consistency, since it is almost the same change in all three cases, and it is good to keep the APIs for those functions consistent since they are closely related mathematically. |
I'd like to not overwhelm @sam0410 with too many not-strictly-necessary requests on a first PR here. |
Hi @StefanKarpinski, I will add the keywords to |
I made a few small edits (we can't deprecate the old method yet, but I've added a note that we should do that in future). |
Thanks for sticking with this! |
Compat annotation for rank(A; rtol=..., atol=...), #29926.
This is for issue number #3249