Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #30303, escaping $ when showing Symbols #30304

Merged
merged 2 commits into from
Dec 8, 2018
Merged

fix #30303, escaping $ when showing Symbols #30304

merged 2 commits into from
Dec 8, 2018

Conversation

JeffBezanson
Copy link
Member

No description provided.

@JeffBezanson JeffBezanson added bugfix This change fixes an existing bug display and printing Aesthetics and correctness of printed representations of objects. backport pending 1.0 labels Dec 7, 2018
vtjnash
vtjnash reviewed Dec 7, 2018
View reviewed changes
base/show.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC mentioned this pull request Dec 7, 2018
Merged
52 tasks
@ararslan ararslan merged commit f0b9499 into master Dec 8, 2018
@ararslan ararslan deleted the jb/fix30303 branch December 8, 2018 02:43
KristofferC pushed a commit that referenced this pull request Dec 9, 2018
@JeffBezanson @KristofferC
fix #30303, escaping $ when showing Symbols (#30304)
36b60b7 
* fix #30303, escaping $ when showing Symbols

* use repr instead of escape_string

(cherry picked from commit f0b9499)
KristofferC pushed a commit that referenced this pull request Dec 30, 2018
@JeffBezanson @KristofferC
fix #30303, escaping $ when showing Symbols (#30304)
d9a3592 
* fix #30303, escaping $ when showing Symbols

* use repr instead of escape_string

(cherry picked from commit f0b9499)
@KristofferC KristofferC mentioned this pull request Dec 30, 2018
Closed
53 tasks
@StefanKarpinski StefanKarpinski added triage This should be discussed on a triage call backport 1.0 and removed triage This should be discussed on a triage call labels Jan 31, 2019
@JeffBezanson JeffBezanson removed backport 1.0 triage This should be discussed on a triage call labels Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vtjnash vtjnash vtjnash left review comments

@ararslan ararslan ararslan approved these changes

@omus omus omus approved these changes

Assignees
No one assigned
Labels
bugfix This change fixes an existing bug display and printing Aesthetics and correctness of printed representations of objects.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@JeffBezanson @vtjnash @omus @ararslan @StefanKarpinski @KristofferC