Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unexport catch_stack #30316

Merged
merged 1 commit into from
Dec 9, 2018
Merged

Unexport catch_stack #30316

merged 1 commit into from
Dec 9, 2018

Conversation

c42f
Copy link
Member

@c42f c42f commented Dec 8, 2018

This API is experimental in julia 1.1 and will be replaced with
something more convenient (see #29901). In the meantime, make sure it's
clearly marked as experimental and not exported from Base.

base/error.jl Outdated Show resolved Hide resolved
base/error.jl Outdated Show resolved Hide resolved
base/error.jl Outdated Show resolved Hide resolved
@KristofferC KristofferC mentioned this pull request Dec 9, 2018
52 tasks
This API is experimental in julia 1.1 and will be replaced with
something more convenient (see #29901). In the meantime, make sure it's
clearly marked as experimental and not exported from Base.
@c42f
Copy link
Member Author

c42f commented Dec 9, 2018

I've got a weird error building the docs locally which I haven't had time to resolve yet (hence the annoying CI breakage, hopefully fixed now). Logs in case you guys have some idea:

chris@xyz:~/dev/julia/doc$ make VERBOSE=1
/home/chris/dev/julia/deps/tools/jlchecksum UnicodeData.txt
Building HTML documentation.
/home/chris/dev/julia/usr/bin/julia --color=yes /home/chris/dev/julia/doc/make.jl linkcheck= doctest= buildroot=/home/chris/dev/julia
  Updating registry at `~/dev/julia/doc/deps/registries/General`
  Updating git-repo `https://github.com/JuliaRegistries/General.git`
ERROR: LoadError: ArgumentError: Package Pkg-193e494c22f7ce8b5956829286c6212133edcbf1 not found in current path:
- Run `import Pkg; Pkg.add("Pkg-193e494c22f7ce8b5956829286c6212133edcbf1")` to install the Pkg-193e494c22f7ce8b5956829286c6212133edcbf1 package.

@KristofferC
Copy link
Member

Delete usr folder and rebuild.

@c42f
Copy link
Member Author

c42f commented Dec 9, 2018

CI error on win32 is #29880

@c42f c42f merged commit 1bd316b into master Dec 9, 2018
@c42f c42f deleted the cjf/unexport-catch-stack branch December 9, 2018 08:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants