Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codegen: disable Bool optimization for maybe-undef fields #30350

Merged
merged 1 commit into from
Dec 12, 2018

Conversation

vtjnash
Copy link
Sponsor Member

@vtjnash vtjnash commented Dec 11, 2018

We don't have a way to mark that the slot may contain invalid data, so just eagerly load it so we can sanitize the value immediately in case it is garbage.

fix #30344

We don't have a way to mark that the slot may contain invalid data,
so just eagerly load it so we can sanitize the value immediately
in case it is garbage.

fix #30344
@JeffBezanson JeffBezanson merged commit 897df72 into master Dec 12, 2018
@JeffBezanson JeffBezanson deleted the jn/30344 branch December 12, 2018 22:34
KristofferC pushed a commit that referenced this pull request Dec 12, 2018
We don't have a way to mark that the slot may contain invalid data,
so just eagerly load it so we can sanitize the value immediately
in case it is garbage.

fix #30344

(cherry picked from commit 897df72)
@KristofferC KristofferC mentioned this pull request Dec 12, 2018
52 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
compiler:codegen Generation of LLVM IR and native code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nullables test error on 1.1.0 branch
4 participants