Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #20409: rank for sparse matrices. #30415

Merged
merged 1 commit into from
Dec 17, 2018
Merged

Fix #20409: rank for sparse matrices. #30415

merged 1 commit into from
Dec 17, 2018

Conversation

ViralBShah
Copy link
Member

No description provided.

@ViralBShah ViralBShah added the sparse Sparse arrays label Dec 17, 2018
@fredrikekre
Copy link
Member

Just want to note that this is type-piracy by SuiteSparse, and might make it more difficult to decouple SuiteSparse, SparseArrays them in the future.

@andreasnoack
Copy link
Member

We should flesh out the possible dependency graphs between SparseArrays, SuiteSparse, and the (currently non-existing) SparseLinearAlgebra packages and discuss benefits and complications.

While it's true that this PR might add to the confusion, I suspect it won't add much work to the eventual decoupling process. A solution could also be to just define this method in the current linearalgebra.jl in SparseArrays and make it call qr anyway. It will then just fail if no sparse QR is available.

@ViralBShah
Copy link
Member Author

The question around separating SparseArrays and SuiteSparse is whether Dense will also roughly split the same functionality into separate packages. Otherwise, we will end up with a real patchwork of what sparse capability lives where and will be different than dense.

@ViralBShah ViralBShah merged commit f36ace9 into master Dec 17, 2018
@ViralBShah ViralBShah deleted the vs/sparserank branch December 17, 2018 14:47
@ViralBShah
Copy link
Member Author

Is this ok to backport, at least to 1.1?

KristofferC pushed a commit that referenced this pull request Jan 11, 2019
@ViralBShah @KristofferC
Fix #20409: rank for sparse matrices. (#30415)
7a7f552 
(cherry picked from commit f36ace9)
@KristofferC KristofferC mentioned this pull request Jan 11, 2019
Closed
53 tasks
@StefanKarpinski StefanKarpinski added backport 1.0 triage This should be discussed on a triage call and removed backport 1.0 triage This should be discussed on a triage call labels Jan 31, 2019
@JeffBezanson JeffBezanson removed backport 1.0 triage This should be discussed on a triage call labels Jan 31, 2019
@vtjnash vtjnash mentioned this pull request Aug 2, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andreasnoack andreasnoack andreasnoack approved these changes

Assignees
No one assigned
Labels
sparse Sparse arrays
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@ViralBShah @fredrikekre @andreasnoack @StefanKarpinski @JeffBezanson