gf: fix jl_isa_compileable_sig again #30458
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
added
bugfix
|
@nanosoldier |
|
Your benchmark job has completed - possible performance regressions were detected. A full report can be found here. cc @ararslan |
This was referenced Dec 27, 2018
Merged
Closed
The last attempts were pretty good, but still missed a lot. But this is what you find when you actually try to test it. This is not too important, but it can reduce compilation performance in some case, so it is not ideal.
vtjnash
force-pushed
the
jn/isa_compileable_sig_again
branch
from
aacc36f
to
0cae91a
Compare
vtjnash
added
backport pending 1.1.1
and removed
backport pending 1.1
needs nanosoldier run
KristofferC
pushed a commit
that referenced
this pull request
Jan 11, 2019
The last attempts were pretty good, but still missed a lot. But this is what you find when you actually try to test it. This is not too important, but it can reduce compilation performance in some case, so it is not ideal. (cherry picked from commit 76e7421)
StefanKarpinski
added
backport 1.1
triage
JeffBezanson
removed
backport 1.0
triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The last attempts were pretty good, but still missed a lot.
But this is what you find when you actually try to test it.
This is not too important, but it can reduce compilation
performance in some case, so it is not ideal.