store more unnecessary information in CodeInfo #31015
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
force-pushed
the
jn/codeinfo-plus
branch
from
dbed009 to
cfe9875
Compare
|
Demo of |
|
vtjnash
force-pushed
the
jn/codeinfo-plus
branch
2 times, most recently
from
8d05c80 to
5064593
Compare
Also store a few other unnecessary properties in CodeInfo, which some users might be interested in having.
Not yet enabled, since we likely need to cache this more efficiently first.
also expose `optimize` flag, and set default to false closes #29287
vtjnash
force-pushed
the
jn/codeinfo-plus
branch
from
5064593 to
42b6571
Compare
|
GTG? It's mostly NFC (since these field are essentially being added with an explicit "no warranty" clause) Though to be clear, this isn't entirely NFC since it is changing the default of |
|
I think that's a reasonable change. |
giordano
pushed a commit
that referenced
this pull request
Oct 31, 2023
`sparam_syms` was removed in #31015. --------- Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We've previously been pretty careful to only have useful information in CodeInfo. That's probably not really necessary though, since having the ability to expose extra information (slottypes, rettype, parent, min/max world) isn't too harmful, and is occasionally useful. Here we use it to close #29287.