Don't export reindex and substrides
#31201
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was inadvertently exported by #30789. It's tailored to `SubArray` and doesn't check for preconditions that are enforced by the `SubArray` constructor — so while we could export it, I'd like to do so intentionally and add friendlier errors for violations of these preconditions.
StefanKarpinski
approved these changes
Feb 28, 2019
|
We should maybe do a review of all added exports before each release. |
|
That's even better! We should make a sprint to get those finished up so that we can require documentation of exports. There's still a slight danger, however, of accidentally exporting something since we do sometimes write docstrings on internal bindings. |
|
Yes, even though we document a bunch of exported stuff now we should imo stiull to an audit to check what things should perhaps be unexported in 2.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These were inadvertently exported by the deprecate macro in #30789. Both are tailored to
SubArrayand don't check for preconditions that are enforced by theSubArrayconstructor. While we could perhaps export them, I'd like to do so intentionally... and add friendlier errors for violations of these preconditions.