-
-
Notifications
You must be signed in to change notification settings - Fork 5.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docstring setindex #32738
Merged
Merged
docstring setindex #32738
Changes from 3 commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
82f64f2
docstring setindex
matbesancon c0f7f1f
noop doc
matbesancon 1adc9c2
trailing whitespace
matbesancon bb92075
Merge branch 'master' into setindex-doc
matbesancon 74a4b9f
add bound check
matbesancon 812757b
fix selectdim implementation
matbesancon File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is that intentional? Seems like odd behavior. I would assume it should boundscheck by default?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea, @vtjnash was the last to edit the line
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Was introduced in #20154 as a simple helper function. The behavior is very much intentional there, but perhaps we should see if we can add a
@boundscheck
block without sacrificing performance if we're going to move towards this being more documented.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wouldn't it be considered as a breaking change then (replacing noop with BoundsError)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not really as it was neither exported nor documented. That's why if we document it, it'd be good to make sure the semantics are what we want.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
FYI StaticArrays.jl does bound check with
setindex
https://github.com/JuliaArrays/StaticArrays.jl/blob/2583967e282b21fd8f8a4e2fc306efc672b4d83d/src/deque.jl#L73-L86