some improvements to the llvm/codegen makefiles #33510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apparently LLVM will still release binaries on releases.llvm.org (and not GitHub), the 8.0.1 release was just an exception.
vtjnash
force-pushed
the
jn/llvm-makefile-cleanup
branch
from
4309177 to
ac9582a
Compare
Keno
reviewed
Oct 9, 2019
| @@ -173,7 +173,7 @@ endif | |||
|
|
|||
| ifneq ($(LLVM_VER),svn) | |||
| ifeq (,$(findstring rc,$(LLVM_VER))) | |||
| ifeq ($(shell [ $(LLVM_VER_MAJ) -ge 8 -a $(LLVM_VER) != 8.0.0 ]; echo $$?),0) | |||
| ifeq ($(shell [ x"$(LLVM_VER)" = x"8.0.1" ]; echo $$?),0) | |||
There was a problem hiding this comment.
Won't this conditional fail for LLVM 9 now?
There was a problem hiding this comment.
yeah, turns out llvm 8.0.1 was the only release they decided not to upload to releases.llvm.org and use a github url instead. I mistakenly assumed that mean they were switching to that.
Keno
reviewed
Oct 9, 2019
| @@ -1,8 +1,14 @@ | |||
| SRCDIR := $(abspath $(dir $(lastword $(MAKEFILE_LIST)))) | |||
| JULIAHOME := $(abspath $(SRCDIR)/../..) | |||
| include $(JULIAHOME)/Make.inc | |||
| test: | |||
|
|
|||
| check: $(SRCDIR) | |||
There was a problem hiding this comment.
update the CI configuration that runs these tests to use the check target instead?
There was a problem hiding this comment.
We don't seem to be hardcoding the name anywhere. Do you know of a case?
There was a problem hiding this comment.
Fair, I guess this is the default target, so things will keep working.
Keno
approved these changes
Oct 9, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.