Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable multiple function composition in prefix form #33568

Merged
merged 16 commits into from
Oct 16, 2019
Merged

Enable multiple function composition in prefix form #33568

merged 16 commits into from
Oct 16, 2019

Commits on Oct 15, 2019

  1. Enable multiple function composition in prefix form 

    Document the prefix form and extend the prefix form to support composition of 3 or more functions.
If there is favorable sentiment for this then I can also add tests.
There was discussion in 2016 about related issues but I don't see anything more recent
#17184
    @JeffFessler
    JeffFessler authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    cdc3e73 View commit details
    Browse the repository at this point in the history

  2. Refine multiple function composition 

    Thanks for the feedback.  Done.
Also added a single doctest that should suffice for codecov.
    @JeffFessler
    JeffFessler authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    7ffb2d9 View commit details
    Browse the repository at this point in the history

  3. Update punctuation and spacing. 

    I also removed "for functions" because composition can work more generally it seems.
    @JeffFessler
    JeffFessler authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    b38c441 View commit details
    Browse the repository at this point in the history

  4. Reword comment 

    Co-Authored-By: Stefan Karpinski <stefan@karpinski.org>
    @JeffFessler @StefanKarpinski
    JeffFessler and StefanKarpinski authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    dee3076 View commit details
    Browse the repository at this point in the history

  5. Expand doctest 

    I was trying to minimize number of lines changed :)

Co-Authored-By: Stefan Karpinski <stefan@karpinski.org>
    @JeffFessler @StefanKarpinski
    JeffFessler and StefanKarpinski authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    d7513a5 View commit details
    Browse the repository at this point in the history

  6. Simplify to a single new line

    @JeffFessler
    JeffFessler authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    4b5eec8 View commit details
    Browse the repository at this point in the history

  7. Add space 

    Co-Authored-By: Stefan Karpinski <stefan@karpinski.org>
    @JeffFessler @StefanKarpinski
    JeffFessler and StefanKarpinski authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    96fd5d7 View commit details
    Browse the repository at this point in the history

  8. More spacing in docstring

    @JeffFessler
    JeffFessler authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    0fea3fb View commit details
    Browse the repository at this point in the history

  9. Cut also 

    Co-Authored-By: Stefan Karpinski <stefan@karpinski.org>
    @JeffFessler @StefanKarpinski
    JeffFessler and StefanKarpinski authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    95f1f89 View commit details
    Browse the repository at this point in the history

  10. Refine docstring 

    I was avoiding the term "function" because an earlier version had unnecessary `Function` typing but I agree that the description is more clear this way.

Co-Authored-By: Stefan Karpinski <stefan@karpinski.org>
    @JeffFessler @StefanKarpinski
    JeffFessler and StefanKarpinski authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    c087b2c View commit details
    Browse the repository at this point in the history

  11. Multiple function composition 

    per #33568
    @JeffFessler
    JeffFessler authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    58b83ec View commit details
    Browse the repository at this point in the history

  12. Add compat 1.4 to docstring

    @JeffFessler
    JeffFessler authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    390ff00 View commit details
    Browse the repository at this point in the history

  13. Add tests for multiple function composition

    @JeffFessler
    JeffFessler authored Oct 15, 2019
    Configuration menu
    Copy the full SHA
    f44dc85 View commit details
    Browse the repository at this point in the history

Commits on Oct 16, 2019

  1. Refine wording

    @JeffFessler
    JeffFessler authored Oct 16, 2019
    Configuration menu
    Copy the full SHA
    357297c View commit details
    Browse the repository at this point in the history

  2. Fix doctest 

    spurious `true` left from older version of doctest
    @JeffFessler
    JeffFessler authored Oct 16, 2019
    Configuration menu
    Copy the full SHA
    df3aec8 View commit details
    Browse the repository at this point in the history

  3. Cut superfluous ()

    @JeffFessler
    JeffFessler authored Oct 16, 2019
    Configuration menu
    Copy the full SHA
    23e88a4 View commit details
    Browse the repository at this point in the history