Add patch for 31156 #34860
Closed
Add patch for 31156 #34860
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This imports the patch I put up in https://reviews.llvm.org/D75072 and should fix #31156. We should probably hold off on merging this for a few days while upstream review is ongoing. In the meantime, this branch should be convenient to try. Make sure to remember to build LLVM from source, not BB.
|
@ianshmean Can you try this out and let us know if it fixes the bug for you? |
|
Already getting started 👍🏻 |
|
Indeed, this fixes #31156 I also just successfully compiled a sysimage with PackageCompiler that was previously failing for this reason 👍🏻❤️ |
|
Ready to merge? |
|
I haven't gotten any feedback upstream, but I do think this patch is ok to do. It's about as minimal as I could make it. |
|
Actually, we should probably add this patch to BB first and add the bump here, so we test this patch on CI. |
Keno
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Mar 2, 2020
Adds the patch from JuliaLang/julia#34860.
Keno
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Mar 4, 2020
Adds the patch from JuliaLang/julia#34860.
staticfloat
added a commit
to JuliaPackaging/Yggdrasil
that referenced
this pull request
Mar 6, 2020
Adds the patch from JuliaLang/julia#34860.
|
Replaced by #35076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This imports the patch I put up in https://reviews.llvm.org/D75072
and should fix #31156. We should probably hold off on merging this
for a few days while upstream review is ongoing. In the meantime,
this branch should be convenient to try. Make sure to remember to build
LLVM from source, not BB.