Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IMO
findmin(sin(x) for x in 0:10)
should return same asfindmin([sin(x) for x in 0:10])
,without allocating. Currently the first call throws a
MethodError
.This PR inserts
key(::Base.Generator)
in order to achieve that.As a consequence also
pairs(::Generator)
,findmin(::Genearator)
,findmax(::Generator)
are working as expected.