Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[LLVM8] patch maintenance #35313

Merged
merged 4 commits into from
Apr 4, 2020
Merged

[LLVM8] patch maintenance #35313

merged 4 commits into from
Apr 4, 2020

Conversation

vchuravy
Copy link
Member

Backport of #35300 also includes #35273

I removed the checksums for the assert build since we traditionally don't include them, but I have yet to push the assert build with these patches since I am watinging for antarctic to be free again.

@vchuravy vchuravy added the external dependencies Involves LLVM, OpenBLAS, or other linked libraries label Mar 30, 2020
@IanButterworth
Copy link
Member

I can confirm that on aarch64 this fixes #31156 (JuliaLang/PackageCompiler.jl#295) 🎉

@KristofferC KristofferC changed the base branch from release-1.4 to backports-release-1.4.1 April 3, 2020 10:25
@KristofferC
Copy link
Member

Changed the base branch to be against the correct one (the one we will run Nanosolider and PkgEval on before merging it into release-1.4)

@KristofferC
Copy link
Member

KristofferC commented Apr 4, 2020

Can this be merged?

@vchuravy vchuravy merged commit 48ee62c into backports-release-1.4.1 Apr 4, 2020
@vchuravy vchuravy deleted the vc/bp_llvm8 branch April 4, 2020 14:52
@vchuravy
Copy link
Member Author

vchuravy commented Apr 4, 2020

Can this be merged?

I was just waiting for you to give me the green-light.

@KristofferC
Copy link
Member

I didn't know if

but I have yet to push the assert build with these patches since I am watinging for antarctic to be free again.

was something that needed to be done first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external dependencies Involves LLVM, OpenBLAS, or other linked libraries
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants