Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve the API of REPL.TerminalMenus #35915

Merged
merged 21 commits into from
Jun 9, 2020
Merged

Improve the API of REPL.TerminalMenus #35915

merged 21 commits into from
Jun 9, 2020

Commits on Jun 2, 2020

  1. Improve style in REPL.TerminalMenus 

    This eliminates camelCase, fixes a typo (which unfortunately
was documented), adds a `const` and type info to the CONFIG dict,
and does some renaming/consolidation. Finally, it eliminates a
dangerous escape hatch from one of the tests.
    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    f602094 View commit details
    Browse the repository at this point in the history

  2. Improve documentation of options

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    191433b View commit details
    Browse the repository at this point in the history

  3. eliminate raw! altogether

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    4d896a5 View commit details
    Browse the repository at this point in the history

  4. Improve the writeline API to prevent leak of internals 

    The old `writeLine` forced the user to take the (undocumented)
step of looking up the cursor character in the internal CONFIG Dict.
We can use the name change as an opportunity to improve the API.
    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    5b86abc View commit details
    Browse the repository at this point in the history

  5. Support starting on a line different from 1 in request

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    3f369a6 View commit details
    Browse the repository at this point in the history

  6. Provide noptions as an alternative to options 

    The only way `options` was being used was to count the number,
so it seems a bit silly to force the user to pass a vector.
This will make it easier to support dynamic menus.
    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    8937a72 View commit details
    Browse the repository at this point in the history

  7. Improve abstraction

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    a955ac0 View commit details
    Browse the repository at this point in the history

  8. Improve support for dynamic menus 

    For menus whose number of options might change as a consequence of
user input (e.g., foldable menus), this prevents indexing errors.
    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    5725a93 View commit details
    Browse the repository at this point in the history

  9. Handle state in menu-printing 

    This should enhance the support for dynamic menus that might change
the number of options offered.
    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    af625a2 View commit details
    Browse the repository at this point in the history

  10. reword

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    5807d79 View commit details
    Browse the repository at this point in the history

  11. more deprecate

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    291305c View commit details
    Browse the repository at this point in the history

  12. Introduce ConfiguredMenu

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    c16b616 View commit details
    Browse the repository at this point in the history

  13. Rename cursor::Bool -> iscursor

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    2ccb78e View commit details
    Browse the repository at this point in the history

  14. Add legacy tests

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    b86c7a3 View commit details
    Browse the repository at this point in the history

  15. Split movement commands for easier testing & add dynamic menu test

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    70a5f63 View commit details
    Browse the repository at this point in the history

  16. Update the docs

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    c64de7e View commit details
    Browse the repository at this point in the history

  17. Wrap raw! in try/catch

    @timholy
    timholy committed Jun 2, 2020
    Configuration menu
    Copy the full SHA
    2b24b82 View commit details
    Browse the repository at this point in the history

Commits on Jun 3, 2020

  1. Allow deprecation of the old RadioMenu/MultiSelectMenu API

    @timholy
    timholy committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    2f4c68a View commit details
    Browse the repository at this point in the history

  2. Add preselection of items in MultiSetMenu 

    Fixes #32349
Closes #32344
    @timholy
    timholy committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    2a6d38b View commit details
    Browse the repository at this point in the history

  3. fix and enhance docs

    @timholy
    timholy committed Jun 3, 2020
    Configuration menu
    Copy the full SHA
    648a06e View commit details
    Browse the repository at this point in the history

Commits on Jun 8, 2020

  1. Add NEWS

    @timholy
    timholy committed Jun 8, 2020
    Configuration menu
    Copy the full SHA
    99eab4e View commit details
    Browse the repository at this point in the history