Optimize write barrier when the child is a perminately allocated object #37043
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently support `Int8`, `UInt8` and `Symbol`. Most useful for `Symbol` since box with known `Int8` or `UInt8` types are almost always allocated locally.
simeonschaub
pushed a commit
to simeonschaub/julia
that referenced
this pull request
Aug 29, 2020
…ct (JuliaLang#37043) Currently support `Int8`, `UInt8` and `Symbol`. Most useful for `Symbol` since box with known `Int8` or `UInt8` types are almost always allocated locally.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently support
Int8,UInt8andSymbol.Most useful for
Symbolsince box with knownInt8orUInt8types are almost always allocated locally which now automatically handled by our llvm pass after #36991.I believe this is the correct way / place to do this. Passing this information to LLVM passes without overhead and without causing any visible change to llvmcall (since this should be an optimization) seems quite hard... As long as type inference is doing a good job there should be little optimization opportunity missing here.
Another 0.4% reduction in sysimg code size...