Add deprecation warning for multiple successive semicolons #37168
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
added
deprecation
|
Thanks, looks good to me. This should have a NEWS entry. |
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
|
@JeffBezanson just saw your suggestion and implemented it. Also added a draft NEWS entry. |
Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
BioTurboNick
force-pushed
the
semicolon-warning
branch
from
e19215c to
a3e400c
Compare
|
I rebased onto the more recent master. Was hoping it would get all tests to pass. I don't think the failures are related though? |
12 tasks
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In preparation for future use of multiple semicolons in an array expression to indicate multi-dimensional concatenation (e.g. #33697), this PR implements a deprecation warning. This syntax is currently allowed but has no effect. Trailing semicolons are still ignored.
But, no one would currently see it due to #35648, unless my suggestion #37164 is implemented.