updating domtrees dynamically, removing all unreachable blocks #37882
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vchuravy
force-pushed
the
vc/dynamicdomtree
branch
from
e27b78f
to
6f6d5a5
Compare
vchuravy
added
the
compiler:optimizer
vchuravy
force-pushed
the
vc/dynamic_snca
branch
2 times, most recently
from
4f5725e
to
f7852e3
Compare
…ons and deletions The DFS tree associated with a CFG now keeps track of postorder as well as preorder numbers. The DFS tree, as well as the state associated with the SNCA algorithm for finding (immediate) dominators is now stored in DomTree and reused for Dynamic SNCA.
…of CFG This is in anticipation of domtrees being added to CFGs.
…n needed Every time a CFG is created, its corresponding dominator tree is as well.
… edges This change only affects statements that we have yet to encounter after killing an edge, while iterating through `IncrementalCompact`. Statements in dead blocks that come before the point at which the edge is killed are killed in `kill_edge!`, when the edge is killed.
If a statement was `nothing`, `kill_edge!` would never move on from trying to kill it because the index wasn't incremented.
vchuravy
force-pushed
the
vc/dynamicdomtree
branch
from
6f6d5a5
to
b32d2b1
Compare
|
@vchuravy I've been reading this code and I think I understand most of it. I want to know what's left to push this PR forward. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rebase of #33730
Latest status update from @yhls was #33730 (comment)
Right now this is causing a compilation error in LLVM, so I suspect I messed up
the rebase or didn't address the changes to the code around it.