add a global cache to the toml parsing in loading and propagate that to precompile processes #37906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timholy
reviewed
Oct 6, 2020
KristofferC
force-pushed
the
kc/propagate_toml_workers
branch
4 times, most recently
from
736c469 to
8393ec6
Compare
timholy
approved these changes
Oct 7, 2020
KristofferC
force-pushed
the
kc/propagate_toml_workers
branch
from
8393ec6 to
70ea160
Compare
…to precompile processes
KristofferC
force-pushed
the
kc/propagate_toml_workers
branch
from
70ea160 to
504a6db
Compare
This was referenced Oct 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #37782
The TOMLCache thing has been kinda annoying. It was supposed to be this internal thing but now Pkg and Revise use it and Revise even has some code for invalidating it. It seems kinda silly that a bunch of packages have to deal with it so I propose we just implement a global cache for it here in Base.
This also propagates the cache to workers so they do not have to reparse them over and over fixing #37632. It is still not at #37632 level where we want to send over the actual paths but it is one step towards it.
This will break
ReviseandPkg.precompile.