Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept RefValue cursor as TerminalMenu request argument. #38393

Merged
merged 2 commits into from
Nov 15, 2020
Merged

Accept RefValue cursor as TerminalMenu request argument. #38393

merged 2 commits into from
Nov 15, 2020

Conversation

GunnarFarneback
Copy link
Contributor

Make the TerminalMenu cursor accessible from outside the request loop, in a backwards compatible way. Cf #35915 (comment).

timholy
timholy reviewed Nov 11, 2020
View reviewed changes
Copy link
Sponsor Member

@timholy timholy left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the code & comment/docs changes, I heartily approve. A test that exploits the new possibilities sure would be nice.

@GunnarFarneback
Copy link
Contributor Author

Test added. Not the most exciting application of this functionality but enjoy playing around with it.

@timholy timholy merged commit 0dd46aa into JuliaLang:master Nov 15, 2020
@GunnarFarneback GunnarFarneback deleted the terminalmenu_cursor branch November 15, 2020 20:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@timholy timholy timholy left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GunnarFarneback @timholy