Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🤖 Bump the NetworkOptions stdlib from 462628a to 32fe926 #38668

Closed
wants to merge 1 commit into from
Closed

🤖 Bump the NetworkOptions stdlib from 462628a to 32fe926 #38668

wants to merge 1 commit into from

Conversation

DilumAluthgeBot
Copy link
Contributor

@DilumAluthgeBot DilumAluthgeBot commented Dec 2, 2020 •
edited
Loading

Stdlib: NetworkOptions
Branch: master
Old commit: 462628a
New commit: 32fe926

$ git log --oneline 462628a..32fe926
32fe926 ssh options: add various options for SSH connections (#9)

@DilumAluthge
Copy link
Member

DilumAluthge commented Dec 3, 2020 •
edited
Loading

@StefanKarpinski Take a look at the test failures.

E.g.

Error in testset NetworkOptions:

Test Failed at /buildworker/worker/tester_linux64/build/share/julia/stdlib/v1.6/NetworkOptions/test/runtests.jl:154

Expression: ssh_known_hosts_files() == [bundled, default]

Evaluated: ["/buildworker/worker/tester_linux64/build/share/julia/stdlib/v1.6/NetworkOptions/src/known_hosts", "/home/buildworker/.ssh/known_hosts", "/buildworker/worker/package_linux64/build/usr/share/julia/stdlib/v1.6/NetworkOptions/src/known_hosts"] == ["/buildworker/worker/tester_linux64/build/share/julia/stdlib/v1.6/NetworkOptions/src/known_hosts", "/home/buildworker/.ssh/known_hosts"]

ERROR: LoadError: Test run finished with errors

@DilumAluthgeBot DilumAluthgeBot deleted the BumpStdlibs/NetworkOptions-32fe926 branch December 3, 2020 05:33
@DilumAluthgeBot DilumAluthgeBot restored the BumpStdlibs/NetworkOptions-32fe926 branch December 3, 2020 05:40
@DilumAluthgeBot DilumAluthgeBot changed the title 🤖 Bump the NetworkOptions stdlib to 32fe926 🤖 Bump the NetworkOptions stdlib from 462628a to 32fe926 Dec 3, 2020
@DilumAluthgeBot DilumAluthgeBot changed the title 🤖 Bump the NetworkOptions stdlib from 462628a to 32fe926 🤖 Bump the NetworkOptions stdlib from 462628a to 32fe926 Dec 3, 2020
@DilumAluthgeBot DilumAluthgeBot changed the title 🤖 Bump the NetworkOptions stdlib from 462628a to 32fe926 🤖 Bump the NetworkOptions stdlib from 462628a to 32fe926 Dec 3, 2020
@StefanKarpinski
Copy link
Sponsor Member

The fact that @__DIR__ is expanded at precompile time is such a footgun. We should really consider making it expand to something that evaluates to the right location at runtime.

@StefanKarpinski
Copy link
Sponsor Member

I'll fix this in NetworkOptions but I've also opened an issue to discuss improving this: #38682.

@StefanKarpinski StefanKarpinski mentioned this pull request Dec 3, 2020
Merged
@DilumAluthgeBot DilumAluthgeBot deleted the BumpStdlibs/NetworkOptions-32fe926 branch December 3, 2020 16:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DilumAluthgeBot @DilumAluthge @StefanKarpinski