make broadcasting into getproperty extensible #39473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Don't know if `dotgetproperty` is a good name for this, since as discussed in #36741, the way this works is a bit different from `dotview`. Right now, `dotproperty` returns a function which is used instead of `getproperty`, but not sure if that is a bit strange and we should just make it behave like `dotview` instead. fixes #36741
simeonschaub
added
compiler:lowering
|
I'm inclined to have it do the operation (i.e. |
|
Yes, that's probably less awkward. |
|
@JeffBezanson Is this good to go? |
JeffBezanson
approved these changes
Mar 11, 2021
vtjnash
added
merge me
|
Would it be possible to have it in 1.6 (or in general in new target Julia LTS release). It would be great for DataFrames.jl users to be able to assume this functionality is always available (otherwise I would need to write in the documentation that some basic functionality like |
|
Feature freeze was a long time ago, so don't think any new features can go into 1.6. |
simeonschaub
removed
the
merge me
ElOceanografo
pushed a commit
to ElOceanografo/julia
that referenced
this pull request
May 4, 2021
* make broadcasting into getproperty extensible Don't know if `dotgetproperty` is a good name for this, since as discussed in JuliaLang#36741, the way this works is a bit different from `dotview`. Right now, `dotproperty` returns a function which is used instead of `getproperty`, but not sure if that is a bit strange and we should just make it behave like `dotview` instead. fixes JuliaLang#36741 * make dotgetproperty call getproperty directly Co-authored-by: Jameson Nash <vtjnash@gmail.com>
antoine-levitt
pushed a commit
to antoine-levitt/julia
that referenced
this pull request
May 9, 2021
* make broadcasting into getproperty extensible Don't know if `dotgetproperty` is a good name for this, since as discussed in JuliaLang#36741, the way this works is a bit different from `dotview`. Right now, `dotproperty` returns a function which is used instead of `getproperty`, but not sure if that is a bit strange and we should just make it behave like `dotview` instead. fixes JuliaLang#36741 * make dotgetproperty call getproperty directly Co-authored-by: Jameson Nash <vtjnash@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Don't know if
dotgetpropertyis a good name for this, since as discussed in #36741, the way this works is a bit different fromdotview. Right now,dotpropertyreturns a function which is used instead ofgetproperty, but not sure if that is a bit strange and we should just make it behave likedotviewinstead.fixes #36741