inference: form conditional constraint from non-Conditional object
#40832
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We can form a conditional constraint from a branch condition itself when its type isn't already `Conditional` but can be refined as `Conditional(condx, Const(true), Const(false))`.
vtjnash
approved these changes
May 19, 2021
There was a problem hiding this comment.
It is potentially even stronger than this, if we could do stupdate! multiple times, but we'd need to keep a list of changes to be able to check if any of them made an update
condt = tmeet(condt, Bool)
newstate_else = stupdate!(states[l], StateUpdate(condx, VarState(Const(false), false), something(newstate_else, changes_else), false)
...
changes = stupdate!(states[pc´], StateUpdate(condx, VarState(Const(true), false), changes, false)
...
|
That's better, yet I'd like to postpone to #40880 the discussion on how to apply multiple state updates. |
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
May 22, 2021
This change addresses JuliaLang#40832 (review)
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
May 23, 2021
This change addresses <JuliaLang#40832 (review)>
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
May 24, 2021
This change addresses <JuliaLang#40832 (review)>
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
May 27, 2021
This change addresses <JuliaLang#40832 (review)>
aviatesk
added a commit
that referenced
this pull request
May 29, 2021
This change addresses <#40832 (review)>
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
Jun 3, 2021
This change addresses <JuliaLang#40832 (review)>
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
Jun 3, 2021
This change addresses <JuliaLang#40832 (review)>
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
Jun 25, 2021
This change addresses <JuliaLang#40832 (review)>
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
Sep 23, 2021
This change addresses <JuliaLang#40832 (review)>
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
Sep 30, 2021
This change addresses <JuliaLang#40832 (review)>
aviatesk
added a commit
to aviatesk/julia
that referenced
this pull request
Jul 22, 2024
This change addresses <JuliaLang#40832 (review)>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We can form a conditional constraint from a branch condition itself
when its type isn't already
Conditionalbut can be refined asConditional(condx, Const(true), Const(false)).