simplify seeding for Xoshiro/TaskLocalRNG/GLOBAL_RNG #41106
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rfourquet
added
randomness
JeffBezanson
approved these changes
Jun 7, 2021
rfourquet
force-pushed
the
rf/xoshiro-seed
branch
from
af5eaff to
83b1847
Compare
1. `seed!(rng::Xoshiro, seed::NTuple{4,UInt64})` and
`seed!(rng::TaskLocalRNG, seed::NTuple{4,UInt64})` were doing almost the same thing;
factor out what was identical;
2. `seed!(rng::Union{TaskLocalRNG, Xoshiro})` was calling the above methods passing
a random tuple generated by `RandomDevice`: in this case, we don't really need
to hash the seed, as it's presumably random enough; so use the same algorithm
as in `Xoshiro()` constructor, and let `Xoshiro()` re-use this new implementation
of `seed!`.
rfourquet
force-pushed
the
rf/xoshiro-seed
branch
from
83b1847 to
143a47f
Compare
KristofferC
pushed a commit
that referenced
this pull request
Jun 17, 2021
1. `seed!(rng::Xoshiro, seed::NTuple{4,UInt64})` and
`seed!(rng::TaskLocalRNG, seed::NTuple{4,UInt64})` were doing almost the same thing;
factor out what was identical;
2. `seed!(rng::Union{TaskLocalRNG, Xoshiro})` was calling the above methods passing
a random tuple generated by `RandomDevice`: in this case, we don't really need
to hash the seed, as it's presumably random enough; so use the same algorithm
as in `Xoshiro()` constructor, and let `Xoshiro()` re-use this new implementation
of `seed!`.
(cherry picked from commit e35028a)
johanmon
pushed a commit
to johanmon/julia
that referenced
this pull request
Jul 5, 2021
1. `seed!(rng::Xoshiro, seed::NTuple{4,UInt64})` and
`seed!(rng::TaskLocalRNG, seed::NTuple{4,UInt64})` were doing almost the same thing;
factor out what was identical;
2. `seed!(rng::Union{TaskLocalRNG, Xoshiro})` was calling the above methods passing
a random tuple generated by `RandomDevice`: in this case, we don't really need
to hash the seed, as it's presumably random enough; so use the same algorithm
as in `Xoshiro()` constructor, and let `Xoshiro()` re-use this new implementation
of `seed!`.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
seed!(rng::Xoshiro, seed::NTuple{4,UInt64})andseed!(rng::TaskLocalRNG, seed::NTuple{4,UInt64})were doing almost the same thing;factor out what was identical;
seed!(rng::Union{TaskLocalRNG, Xoshiro})was calling the above methods passinga random tuple generated by
RandomDevice: in this case, we don't really needto hash the seed, as it's presumably random enough; so use the same algorithm
as in
Xoshiro()constructor, and letXoshiro()re-use this new implementationof
seed!.