Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add world age and interpreter arguments to code_warntype. #41149

Merged
merged 2 commits into from
Jun 10, 2021

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 9, 2021

No description provided.

Copy link
Member

@simeonschaub simeonschaub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me.

@oscardssmith
Copy link
Member

Why does this need back-porting?

@maleadt
Copy link
Member Author

maleadt commented Jun 9, 2021

Why does this need back-porting?

It's a backport to the just-branched 1.7 release.

The GPU stack, and other packages, use their own AbstractInterpreter. Lacking a way to call reflection without these args, code_warntype is essentially broken for GPU code now that we start to rely more heavily on custom compilation (e.g. with #39697).

@maleadt maleadt force-pushed the tb/codeview_interp branch from 5c64c21 to 46e052d Compare June 9, 2021 16:08
@maleadt
Copy link
Member Author

maleadt commented Jun 10, 2021

The doctest failure is caused by this PR (default value of optimize kwargs is different with code_warntype vs code_typed), so don't merge this yet.

@maleadt maleadt force-pushed the tb/codeview_interp branch from 46e052d to 0a00864 Compare June 10, 2021 09:05
@maleadt maleadt merged commit 15c19c8 into master Jun 10, 2021
@maleadt maleadt deleted the tb/codeview_interp branch June 10, 2021 11:26
KristofferC pushed a commit that referenced this pull request Jun 17, 2021
@KristofferC KristofferC mentioned this pull request Jun 17, 2021
20 tasks
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants