Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes for overlay tables #41174

Merged
merged 3 commits into from
Jun 14, 2021
Merged

Fixes for overlay tables #41174

merged 3 commits into from
Jun 14, 2021

Conversation

maleadt
Copy link
Member

@maleadt maleadt commented Jun 10, 2021

Re #41137 (comment)

@vtjnash I wanted to do #41137 (comment), but the checks from jl_check_open_for fail up during precompilation tests when kwftype ends up calling jl_new_method_table:

ERROR: LoadError: Evaluation into the closed module `Base` breaks incremental compilation because
the side effects will not be permanent. This is likely due to some other module mutating `Base` with
`jl_new_method_table` during precompilation - don't do this.

jl_check_open_for at /home/tim/Julia/src/julia/src/toplevel.c:916
jl_new_method_table at /home/tim/Julia/src/julia/src/datatype.c:49
jl_new_datatype at /home/tim/Julia/src/julia/src/datatype.c:598
jl_new_generic_function_with_supertype at /home/tim/Julia/src/julia/src/gf.c:2540
jl_get_kwsorter at /home/tim/Julia/src/julia/src/gf.c:2578
kwftype at ./boot.jl:377

@maleadt maleadt requested a review from vtjnash June 10, 2021 14:50
@JeffBezanson JeffBezanson merged commit 27ef9e0 into master Jun 14, 2021
@JeffBezanson JeffBezanson deleted the tb/fixup_overlay branch June 14, 2021 19:38
KristofferC pushed a commit that referenced this pull request Jun 17, 2021
@maleadt @KristofferC
Fixes for overlay tables (#41174)
6daa48e 
* Add support for at-overlay with parametric function definitions.

* Fix error message with at-MethodTable.

* Fix function signature to avoid compiler warning.

(cherry picked from commit 27ef9e0)
@KristofferC KristofferC mentioned this pull request Jun 17, 2021
Merged
20 tasks
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
@maleadt @johanmon
Fixes for overlay tables (JuliaLang#41174)
055a19d 
* Add support for at-overlay with parametric function definitions.

* Fix error message with at-MethodTable.

* Fix function signature to avoid compiler warning.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JeffBezanson JeffBezanson JeffBezanson approved these changes

@vtjnash vtjnash Awaiting requested review from vtjnash

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@maleadt @JeffBezanson @KristofferC