Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Code coverage: fix the code coverage pipeline #41375

Merged
merged 2 commits into from
Jun 26, 2021
Merged

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jun 26, 2021

The uploads to Codecov and Coveralls are failing because we are in a "detached HEAD" situation.

This PR should fix the failures by getting the branch and commit information from the Buildkite environment variables.

@DilumAluthge DilumAluthge added ci Continuous integration code coverage labels Jun 26, 2021
@DilumAluthge DilumAluthge changed the title Code coverage: fix the Coveralls upload Code coverage: fix the code coverage pipeline Jun 26, 2021
@DilumAluthge DilumAluthge added the bugfix This change fixes an existing bug label Jun 26, 2021
@DilumAluthge DilumAluthge force-pushed the dpa/fix-coverage branch 6 times, most recently from e2be560 to 59e917c Compare June 26, 2021 12:12
@codecov
Copy link

codecov bot commented Jun 26, 2021

Codecov Report

Merging #41375 (a4c80f3) into master (004cb25) will decrease coverage by 5.79%.
The diff coverage is 69.24%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #41375      +/-   ##
==========================================
- Coverage   86.15%   80.35%   -5.80%     
==========================================
  Files         350      350              
  Lines       65991    73630    +7639     
==========================================
+ Hits        56854    59169    +2315     
- Misses       9137    14461    +5324     
Impacted Files Coverage Δ
base/atomics.jl 84.00% <ø> (+0.66%) ⬆️
base/baseext.jl 94.73% <ø> (ø)
base/compiler/ssair/verify.jl 1.48% <0.00%> (-52.37%) ⬇️
base/compiler/typelattice.jl 80.38% <ø> (-10.71%) ⬇️
base/compiler/typelimits.jl 31.73% <ø> (-61.20%) ⬇️
base/compiler/types.jl 66.66% <ø> (-3.34%) ⬇️
base/compiler/typeutils.jl 64.45% <ø> (-17.90%) ⬇️
base/compiler/utilities.jl 82.56% <ø> (-4.10%) ⬇️
base/compiler/validation.jl 5.50% <ø> (-82.85%) ⬇️
base/complex.jl 99.43% <ø> (-0.16%) ⬇️
... and 513 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 12e7223...a4c80f3. Read the comment docs.

@DilumAluthge DilumAluthge marked this pull request as ready for review June 26, 2021 12:35
@DilumAluthge DilumAluthge requested a review from a team as a code owner June 26, 2021 12:35
@DilumAluthge DilumAluthge removed the request for review from a team June 26, 2021 14:19
@DilumAluthge DilumAluthge marked this pull request as draft June 26, 2021 14:22
@DilumAluthge DilumAluthge marked this pull request as ready for review June 26, 2021 15:05
@DilumAluthge
Copy link
Member Author

@DilumAluthge DilumAluthge merged commit 05e4138 into master Jun 26, 2021
@DilumAluthge DilumAluthge deleted the dpa/fix-coverage branch June 26, 2021 15:25
johanmon pushed a commit to johanmon/julia that referenced this pull request Jul 5, 2021
* Code coverage: fix the code coverage pipeline

* Run all tests
@KristofferC KristofferC added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 13, 2021
@KristofferC KristofferC mentioned this pull request Jul 19, 2021
75 tasks
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
* Code coverage: fix the code coverage pipeline

* Run all tests

(cherry picked from commit 05e4138)
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
* Code coverage: fix the code coverage pipeline

* Run all tests

(cherry picked from commit 05e4138)
KristofferC pushed a commit that referenced this pull request Jul 20, 2021
* Code coverage: fix the code coverage pipeline

* Run all tests

(cherry picked from commit 05e4138)
KristofferC pushed a commit that referenced this pull request Aug 31, 2021
* Code coverage: fix the code coverage pipeline

* Run all tests

(cherry picked from commit 05e4138)
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
* Code coverage: fix the code coverage pipeline

* Run all tests

(cherry picked from commit 05e4138)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
* Code coverage: fix the code coverage pipeline

* Run all tests

(cherry picked from commit 05e4138)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix This change fixes an existing bug ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants