Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CI (rootfs images): when uploading a tarball, don't allow it to override an existing tarball (unless the user provides the --force-overwrite command-line flag) #41591

Merged
merged 1 commit into from
Jul 15, 2021
Merged

CI (rootfs images): when uploading a tarball, don't allow it to override an existing tarball (unless the user provides the --force-overwrite command-line flag) #41591

merged 1 commit into from
Jul 15, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Jul 15, 2021 •
edited
Loading

Fixes #41590

@DilumAluthge DilumAluthge added ci Continuous integration backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Jul 15, 2021
@DilumAluthge DilumAluthge requested a review from staticfloat July 15, 2021 04:13
@DilumAluthge DilumAluthge requested a review from a team as a code owner July 15, 2021 04:13
@DilumAluthge DilumAluthge removed the request for review from a team July 15, 2021 04:17
@DilumAluthge DilumAluthge changed the title [CI] (rootfs images): when uploading a tarball, don't allow it to override an existing tarball (unless the user provides the --force-overwrite command-line flag CI (rootfs images): when uploading a tarball, don't allow it to override an existing tarball (unless the user provides the --force-overwrite command-line flag Jul 15, 2021
@DilumAluthge DilumAluthge changed the title CI (rootfs images): when uploading a tarball, don't allow it to override an existing tarball (unless the user provides the --force-overwrite command-line flag CI (rootfs images): when uploading a tarball, don't allow it to override an existing tarball (unless the user provides the --force-overwrite command-line flag) Jul 15, 2021
@DilumAluthge DilumAluthge force-pushed the dpa/bk-rootfs-overwrite branch 2 times, most recently from 624b75c to bc4bb5b Compare July 15, 2021 04:27
staticfloat
staticfloat approved these changes Jul 15, 2021
View reviewed changes
.buildkite/rootfs_images/rootfs_utils.jl Outdated Show resolved Hide resolved
@DilumAluthge @staticfloat
CI (rootfs images): when uploading a tarball, don't allow it to overr…
0edd917 
…ide an existing tarball (unless the user provides the `--force-overwrite` command-line flag)

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
@DilumAluthge DilumAluthge force-pushed the dpa/bk-rootfs-overwrite branch from 7070ac4 to 0edd917 Compare July 15, 2021 19:38
@staticfloat staticfloat merged commit 3ac7c38 into master Jul 15, 2021
@staticfloat staticfloat deleted the dpa/bk-rootfs-overwrite branch July 15, 2021 22:55
@DilumAluthge DilumAluthge mentioned this pull request Jul 16, 2021
Merged
@KristofferC KristofferC mentioned this pull request Jul 19, 2021
Merged
75 tasks
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
@DilumAluthge @KristofferC
CI (rootfs images): when uploading a tarball, don't allow it to overr…
90317f8 
…ide an existing tarball (unless the user provides the `--force-overwrite` command-line flag) (#41591)

Co-authored-by: Elliot Saba <staticfloat@gmail.com>

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 3ac7c38)
KristofferC pushed a commit that referenced this pull request Jul 19, 2021
@DilumAluthge @KristofferC
CI (rootfs images): when uploading a tarball, don't allow it to overr…
ad72e9a 
…ide an existing tarball (unless the user provides the `--force-overwrite` command-line flag) (#41591)

Co-authored-by: Elliot Saba <staticfloat@gmail.com>

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 3ac7c38)
@KristofferC KristofferC mentioned this pull request Jul 19, 2021
Merged
82 tasks
KristofferC pushed a commit that referenced this pull request Jul 20, 2021
@DilumAluthge @KristofferC
CI (rootfs images): when uploading a tarball, don't allow it to overr…
1bd94a2 
…ide an existing tarball (unless the user provides the `--force-overwrite` command-line flag) (#41591)

Co-authored-by: Elliot Saba <staticfloat@gmail.com>

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 3ac7c38)
KristofferC pushed a commit that referenced this pull request Jul 20, 2021
@DilumAluthge @KristofferC
CI (rootfs images): when uploading a tarball, don't allow it to overr…
99d27f6 
…ide an existing tarball (unless the user provides the `--force-overwrite` command-line flag) (#41591)

Co-authored-by: Elliot Saba <staticfloat@gmail.com>

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 3ac7c38)
@KristofferC KristofferC mentioned this pull request Aug 25, 2021
Merged
63 tasks
KristofferC pushed a commit that referenced this pull request Aug 31, 2021
@DilumAluthge @KristofferC
CI (rootfs images): when uploading a tarball, don't allow it to overr…
b58efb1 
…ide an existing tarball (unless the user provides the `--force-overwrite` command-line flag) (#41591)

Co-authored-by: Elliot Saba <staticfloat@gmail.com>

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 3ac7c38)
KristofferC pushed a commit that referenced this pull request Sep 3, 2021
@DilumAluthge @KristofferC
CI (rootfs images): when uploading a tarball, don't allow it to overr…
5480733 
…ide an existing tarball (unless the user provides the `--force-overwrite` command-line flag) (#41591)

Co-authored-by: Elliot Saba <staticfloat@gmail.com>

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 3ac7c38)
@KristofferC KristofferC removed the backport 1.6 Change should be backported to release-1.6 label Sep 7, 2021
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
@DilumAluthge @staticfloat
CI (rootfs images): when uploading a tarball, don't allow it to overr…
16acd27 
…ide an existing tarball (unless the user provides the `--force-overwrite` command-line flag) (#41591)

Co-authored-by: Elliot Saba <staticfloat@gmail.com>

Co-authored-by: Elliot Saba <staticfloat@gmail.com>
(cherry picked from commit 3ac7c38)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@staticfloat staticfloat staticfloat approved these changes

Assignees
No one assigned
Labels
ci Continuous integration
Projects
None yet
Milestone
No milestone
3 participants
@DilumAluthge @staticfloat @KristofferC