fix a case where Vararg.T might be accessed when undefined #41867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vtjnash
approved these changes
Aug 12, 2021
|
We have unit tests for this function, so you could add one to those |
aviatesk
approved these changes
Aug 12, 2021
JeffBezanson
force-pushed
the
jb/undefvarargt
branch
from
2d195be to
3c6467a
Compare
|
Is this ready to merge? |
DilumAluthge
removed
the
merge me
KristofferC
pushed a commit
that referenced
this pull request
Aug 25, 2021
(cherry picked from commit 7a784de)
63 tasks
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This came up during the Dash.jl tests while testing #41795. I haven't reduced it but this seems pretty safe anyway.