Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use separate names for internal and exported functions #42151

Merged
merged 10 commits into from
Sep 27, 2021

Conversation

vtjnash
Copy link
Member

@vtjnash vtjnash commented Sep 7, 2021

helps avoid linker errors and confusion

@vtjnash vtjnash force-pushed the jn/internalize-symbols branch 5 times, most recently from ed397cd to 1ea659d Compare September 15, 2021 19:26
@vtjnash vtjnash force-pushed the jn/internalize-symbols branch from 1ea659d to 9e128bc Compare September 16, 2021 16:16
@vtjnash vtjnash force-pushed the jn/internalize-symbols branch from 9e128bc to 9daf97d Compare September 16, 2021 16:26
@vtjnash
Copy link
Member Author

vtjnash commented Sep 16, 2021

Now updated to also transparently include support for #42267

Copy link
Member

@staticfloat staticfloat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can only comment on the loader aspect of this, but looks good to me!

src/Makefile Outdated Show resolved Hide resolved
@vtjnash vtjnash merged commit f5d944c into master Sep 27, 2021
@vtjnash vtjnash deleted the jn/internalize-symbols branch September 27, 2021 19:32
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
helps avoid linker errors and confusion

Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
helps avoid linker errors and confusion

Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants