Fix Printf for typemin(<:Base.BitSigned)

[petvana]

PR aims to fix #41971 . I've utilized the idea from @Seelengrab to use unsigned(). Since overflow is not well-defined for signed types, I've added one not to overflow at all. It seems there is no significant performance influence. Cc: @quinnj.

[Seelengrab]

Thanks for the PR!

Overflow of signed types is well defined in julia - it results in wraparound behavior. See the docs on Overflow Behavior for details.

scratched bit about unsigned - numbers != typemin(T) need adjustment of course..

[Seelengrab]

What about x = unsigned(abs(arg2))? That fixes the problematic case and avoids any conversion problems, since the typemin is handled by unsigned and all other negative values are handled by abs (since they're guaranteed to still fit into the original type).

[petvana]

Thanks for the comment, I have updated to x = unsigned(neg ? -arg2 : arg2) to be closer to the original code with the same meaning.

[Seelengrab]

Alright, other than possibly using abs instead of the ternary, LGTM.

[petvana]

Alright, other than possibly using abs instead of the ternary, LGTM.

An alternative would be to use both abs and ternary in one-liner code. ;-) I can update if preferred.
x = typeof(arg2) <: Base.BitSigned ? unsigned(abs(arg2)) : abs(arg2)

[quinnj]

Sorry for not reviewing this sooner; lgtm. Thanks @petvana!