add keepat! for in-place logical filtering #42351
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
JeffBezanson
commented
Sep 22, 2021
JeffBezanson
commented
- Rebase add keepat! for in-place logical filtering #39528
- Define keepat! only on Vector and BitVector, like deleteat!, fixing keepat! and deleteat!: inconsistencies and possible bugs #42065
Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: Jeff Bezanson <jeff.bezanson@gmail.com>
JeffBezanson
force-pushed
the
MasonProtter-filter_mask
branch
from
f5d936b
to
847ac42
Compare
|
It seems to me the BoundsError in |
84 tasks
KristofferC
pushed a commit
that referenced
this pull request
Sep 28, 2021
Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: MasonProtter <mason.protter@icloud.com>
KristofferC
pushed a commit
that referenced
this pull request
Sep 29, 2021
Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: MasonProtter <mason.protter@icloud.com> (cherry picked from commit b9fba13)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: MasonProtter <mason.protter@icloud.com>
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
Co-authored-by: Jameson Nash <vtjnash@gmail.com> Co-authored-by: MasonProtter <mason.protter@icloud.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.