optimizer: improve general code quality #42357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aviatesk
added
the
compiler:optimizer
aviatesk
changed the title
vtjnash
reviewed
Sep 23, 2021
base/compiler/ssair/passes.jl
Outdated
| @@ -110,7 +110,8 @@ function compute_value_for_use(ir::IRCode, domtree::DomTree, allblocks::Vector{I | |||
| end | |||
| end | |||
|
|
|||
| function simple_walk(compact::IncrementalCompact, @nospecialize(defssa#=::AnySSAValue=#), pi_callback=(pi, idx)->false) | |||
| function simple_walk(compact::IncrementalCompact, @nospecialize(defssa::AnySSAValue), | |||
There was a problem hiding this comment.
Declaring a type on a @nospecialize argument is normally a bad idea, as it may severely penalize the call
There was a problem hiding this comment.
Would you mind elaborating it ?
@nospecialize influences dispatches only at this moment, and I think every call of this function will be statically resolved anyway. And so I don't think there is any other effects than now we can get MethodError for wrong defssa types.
There was a problem hiding this comment.
it removes it from the dispatch cache
vtjnash
reviewed
Sep 23, 2021
base/compiler/ssair/passes.jl
Outdated
| @@ -148,12 +149,12 @@ function simple_walk(compact::IncrementalCompact, @nospecialize(defssa#=::AnySSA | |||
| end | |||
| end | |||
|
|
|||
| function simple_walk_constraint(compact::IncrementalCompact, @nospecialize(defidx), @nospecialize(typeconstraint) = types(compact)[defidx]) | |||
| function simple_walk_constraint(compact::IncrementalCompact, @nospecialize(defssa::AnySSAValue), @nospecialize(typeconstraint) = types(compact)[defssa]) | |||
vtjnash
reviewed
Sep 23, 2021
Comment on lines
+759
to
+763
| # global assertion_counter | ||
| # assertion_counter::Int += 1 |
There was a problem hiding this comment.
We need another optimizer that optimizes our optimizer :p
There was a problem hiding this comment.
A bit seriously, we may want to put more efforts on integrating JET with Julia base.
aviatesk
force-pushed
the
avi/sroa2
branch
3 times, most recently
from
a023da6 to
d936b81
Compare
|
Should be good to go once CI passes successfully. |
Built on top of #42355: - add more type signatures - add more `@nospecialize` decls - remove dead/debug code - add some docs on SROA and ADCE passes
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
- add more type signatures - add more `@nospecialize` decls - remove dead/debug code - add some docs on SROA and ADCE passes
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
- add more type signatures - add more `@nospecialize` decls - remove dead/debug code - add some docs on SROA and ADCE passes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Built on top of #42355:
@nospecializedecls for callbacks