Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix atomicfields serialization for system image #42388

Closed
wants to merge 1 commit into from

Conversation

tkf
Copy link
Member

@tkf tkf commented Sep 26, 2021

fix #42387

@tkf
Copy link
Member Author

tkf commented Sep 26, 2021

@DilumAluthge Do I need to push the branch in JuliaLang/julia for running CI on https://buildkite.com/julialang/julia-master-experimental ?

@DilumAluthge
Copy link
Member

Yeah you can't trigger a manual build if the branch isn't in the main repo.

@tkf
Copy link
Member Author

tkf commented Sep 26, 2021

Gotcha. Thanks.

@tkf tkf closed this Sep 26, 2021
@tkf tkf deleted the fix-sysimg-atomicfields branch September 26, 2021 17:48
@tkf
Copy link
Member Author

tkf commented Sep 26, 2021

@DilumAluthge I re-opened the PR as #42390 but https://buildkite.com/julialang/julia-master-experimental doesn't seem to show the build. Or do I just need to wait?

@DilumAluthge
Copy link
Member

Oh that's right, I disabled experimental CI on PRs.

I manually triggered a build: https://buildkite.com/julialang/julia-master-experimental/builds/2016#6b04cc17-ccb0-4837-9d92-d1607bf000a3

On a separate note, I'll probably promote asan from "experimental" to "regular" soon, and then it'll run on PRs automatically.

@tkf
Copy link
Member Author

tkf commented Sep 26, 2021

I see. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ASAN detects heap-buffer-overflow when writing atomic fields in system image
2 participants