Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add some devdocs for new_opaque_closure #42418

Merged
merged 3 commits into from
Sep 29, 2021
Merged

add some devdocs for new_opaque_closure #42418

merged 3 commits into from
Sep 29, 2021

Conversation

simeonschaub
Copy link
Member

No description provided.

@simeonschaub simeonschaub added the docs This change adds or pertains to documentation label Sep 28, 2021
@simeonschaub simeonschaub requested a review from Keno September 28, 2021 20:46
simeonschaub and others added 2 commits September 28, 2021 17:34
@simeonschaub @nickrobinson251
Update doc/src/devdocs/ast.md
e4fd2f2 
Co-authored-by: Nick Robinson <nicholas.robinson@invenialabs.co.uk>
@simeonschaub
fix whitespace
c6ed7d7
Keno
Keno approved these changes Sep 28, 2021
View reviewed changes
Copy link
Member

@Keno Keno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Probably needs much more explanation on what the semantics actually are, but this seems correct and least and incomplete is better than nothing.

@simeonschaub
Copy link
Member Author

Yeah, I just wanted to write this down somewhere for myself, because I needed to look this up again.

@simeonschaub simeonschaub added the merge me PR is reviewed. Merge when all tests are passing label Sep 28, 2021
@simeonschaub simeonschaub merged commit 1dc1ba1 into master Sep 29, 2021
@simeonschaub simeonschaub deleted the sds/document_new_opaque_closure branch September 29, 2021 00:35
@simeonschaub simeonschaub removed the merge me PR is reviewed. Merge when all tests are passing label Sep 29, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@simeonschaub @nickrobinson251 @LilithHafner
add some devdocs for new_opaque_closure (JuliaLang#42418)
c1b5472 
Co-authored-by: Nick Robinson <nicholas.robinson@invenialabs.co.uk>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@simeonschaub @nickrobinson251 @LilithHafner
add some devdocs for new_opaque_closure (JuliaLang#42418)
a51597f 
Co-authored-by: Nick Robinson <nicholas.robinson@invenialabs.co.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nickrobinson251 nickrobinson251 nickrobinson251 left review comments

@Keno Keno Keno approved these changes

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@simeonschaub @Keno @nickrobinson251