Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support SANITIZE_THREAD in llvm.mk #42468

Merged
merged 1 commit into from
Oct 2, 2021
Merged

Support SANITIZE_THREAD in llvm.mk #42468

merged 1 commit into from
Oct 2, 2021

Conversation

tkf
Copy link
Member

@tkf tkf commented Oct 2, 2021

Previously, it looks like that it was implicitly assumed that LLVM_SANITIZE means ASAN when SANITIZE_MEMORY is not set

julia/deps/llvm-options.mk

Lines 15 to 21 in eb0ab3c

ifeq ($(LLVM_SANITIZE),1)
ifeq ($(SANITIZE_MEMORY),1)
LLVM_BUILDTYPE := $(LLVM_BUILDTYPE)+MSAN
else
LLVM_BUILDTYPE := $(LLVM_BUILDTYPE)+ASAN
endif
endif

This patch adds a branch for SANITIZE_THREAD as well.

(I can compile LLVM with this patch but still haven't managed to compile julia with TSAN yet.)

@vtjnash vtjnash merged commit f1baec3 into JuliaLang:master Oct 2, 2021
@tkf tkf deleted the tsan-make branch October 2, 2021 20:51
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@tkf @LilithHafner
Support SANITIZE_THREAD in llvm.mk (JuliaLang#42468)
f9fadd3
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@tkf @LilithHafner
Support SANITIZE_THREAD in llvm.mk (JuliaLang#42468)
69d42a9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tkf @vtjnash