[buildkite] Fix env leakage of signed tokens #42526
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After a few days of debugging, the buildkite people figured out that the reason our "unprivileged" jobs were getting privileges was because of an obscure behavior of top-level `env:` blocks. To fix it, we should always scope our `env:` mappings to a particular step, and so that's exactly what this does. We also add a `.gitignore` mapping for the new, more convenient way that `cryptic` likes to store keys in the repository.
DilumAluthge
approved these changes
Oct 7, 2021
DilumAluthge
added
backport 1.6
|
For now, let's continue to backport all CI PRs to 1.6 and 1.7. |
KristofferC
pushed a commit
that referenced
this pull request
Oct 11, 2021
After a few days of debugging, the buildkite people figured out that the reason our "unprivileged" jobs were getting privileges was because of an obscure behavior of top-level `env:` blocks. To fix it, we should always scope our `env:` mappings to a particular step, and so that's exactly what this does. We also add a `.gitignore` mapping for the new, more convenient way that `cryptic` likes to store keys in the repository. (cherry picked from commit 39fd36c)
84 tasks
KristofferC
pushed a commit
that referenced
this pull request
Oct 19, 2021
After a few days of debugging, the buildkite people figured out that the reason our "unprivileged" jobs were getting privileges was because of an obscure behavior of top-level `env:` blocks. To fix it, we should always scope our `env:` mappings to a particular step, and so that's exactly what this does. We also add a `.gitignore` mapping for the new, more convenient way that `cryptic` likes to store keys in the repository. (cherry picked from commit 39fd36c)
95 tasks
66 tasks
KristofferC
pushed a commit
that referenced
this pull request
Nov 11, 2021
After a few days of debugging, the buildkite people figured out that the reason our "unprivileged" jobs were getting privileges was because of an obscure behavior of top-level `env:` blocks. To fix it, we should always scope our `env:` mappings to a particular step, and so that's exactly what this does. We also add a `.gitignore` mapping for the new, more convenient way that `cryptic` likes to store keys in the repository. (cherry picked from commit 39fd36c)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
After a few days of debugging, the buildkite people figured out that the reason our "unprivileged" jobs were getting privileges was because of an obscure behavior of top-level `env:` blocks. To fix it, we should always scope our `env:` mappings to a particular step, and so that's exactly what this does. We also add a `.gitignore` mapping for the new, more convenient way that `cryptic` likes to store keys in the repository.
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
After a few days of debugging, the buildkite people figured out that the reason our "unprivileged" jobs were getting privileges was because of an obscure behavior of top-level `env:` blocks. To fix it, we should always scope our `env:` mappings to a particular step, and so that's exactly what this does. We also add a `.gitignore` mapping for the new, more convenient way that `cryptic` likes to store keys in the repository.
staticfloat
added a commit
that referenced
this pull request
Dec 23, 2022
After a few days of debugging, the buildkite people figured out that the reason our "unprivileged" jobs were getting privileges was because of an obscure behavior of top-level `env:` blocks. To fix it, we should always scope our `env:` mappings to a particular step, and so that's exactly what this does. We also add a `.gitignore` mapping for the new, more convenient way that `cryptic` likes to store keys in the repository. (cherry picked from commit 39fd36c)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.