Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI (Buildkite): add a separate Buildkite job that runs the tests of the network-related stdlibs (e.g. Downloads.jl), and automatically retries that job up to a maximum number of tries #42861

Merged
merged 1 commit into from
Oct 31, 2021

Conversation

DilumAluthge
Copy link
Member

@DilumAluthge DilumAluthge commented Oct 30, 2021

This is the first part of the implementation of #42853.

Right now, the only "network-related" tests in this job are:

  • Downloads
  • LibGit2/online
  • download

However, once I fix some of the bugs in the Pkg test suite, I will add Pkg to that list. This will probably be done in a follow-up PR.

@DilumAluthge DilumAluthge added ci Continuous integration backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Oct 30, 2021
@DilumAluthge DilumAluthge requested a review from a team as a code owner October 30, 2021 07:19
@DilumAluthge DilumAluthge removed the request for review from a team October 30, 2021 07:20
@DilumAluthge DilumAluthge force-pushed the dpa/network-stdlib-tests-buildkite branch 2 times, most recently from c9f9246 to b28e50d Compare October 30, 2021 08:15
@DilumAluthge DilumAluthge added the merge me PR is reviewed. Merge when all tests are passing label Oct 30, 2021
@staticfloat
Copy link
Member

This looks about right to me!

…he network-related stdlibs (e.g. Downloads.jl), and automatically retries that job up to a maximum number of tries
@DilumAluthge DilumAluthge force-pushed the dpa/network-stdlib-tests-buildkite branch from 5ec321b to 482b882 Compare October 30, 2021 23:29
@jonas-schulze
Copy link
Contributor

The Distributed tests could be added here as well.

Also, it might be better to test each group of the network related tests on its own. Every single group might pass within x tries, while the combination of all of them would still fail.

@DilumAluthge DilumAluthge merged commit 3003742 into master Oct 31, 2021
@DilumAluthge DilumAluthge deleted the dpa/network-stdlib-tests-buildkite branch October 31, 2021 08:23
@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Oct 31, 2021
KristofferC pushed a commit that referenced this pull request Oct 31, 2021
…he network-related stdlibs (e.g. Downloads.jl), and automatically retries that job up to a maximum number of tries (#42861)

(cherry picked from commit 3003742)
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
…he network-related stdlibs (e.g. Downloads.jl), and automatically retries that job up to a maximum number of tries (#42861)

(cherry picked from commit 3003742)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
…he network-related stdlibs (e.g. Downloads.jl), and automatically retries that job up to a maximum number of tries (#42861)

(cherry picked from commit 3003742)
KristofferC pushed a commit that referenced this pull request Nov 12, 2021
…he network-related stdlibs (e.g. Downloads.jl), and automatically retries that job up to a maximum number of tries (#42861)

(cherry picked from commit 3003742)
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
…he network-related stdlibs (e.g. Downloads.jl), and automatically retries that job up to a maximum number of tries (JuliaLang#42861)
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
…he network-related stdlibs (e.g. Downloads.jl), and automatically retries that job up to a maximum number of tries (JuliaLang#42861)
staticfloat pushed a commit that referenced this pull request Dec 23, 2022
…he network-related stdlibs (e.g. Downloads.jl), and automatically retries that job up to a maximum number of tries (#42861)

(cherry picked from commit 3003742)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci Continuous integration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants