Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Eliminate @loader_path/julia element of DL_LOAD_PATH #42930

Merged
merged 1 commit into from
Nov 4, 2021

Conversation

staticfloat
Copy link
Member

Analogous to 236523f, we don't need to search in @loader_path/julia anymore, as libjulia-internal is now consistently within the same directory as our other dependencies.

Analogous to 236523f, we don't need to search in `@loader_path/julia` anymore, as `libjulia-internal` is now consistently within the same directory as our other dependencies.
@codecov
Copy link

codecov bot commented Nov 4, 2021

Codecov Report

Merging #42930 (236523f) into master (236523f) will not change coverage.
The diff coverage is n/a.

❗ Current head 236523f differs from pull request most recent head 30861bd. Consider uploading reports for the commit 30861bd to get more accurate results
Impacted file tree graph

@@           Coverage Diff           @@
##           master   #42930   +/-   ##
=======================================
  Coverage   89.20%   89.20%           
=======================================
  Files         343      343           
  Lines       79912    79912           
=======================================
  Hits        71285    71285           
  Misses       8627     8627           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 236523f...30861bd. Read the comment docs.

@ararslan
Copy link
Member

ararslan commented Nov 4, 2021

This seems to fix #42882 for me.

@staticfloat
Copy link
Member Author

@ararslan
Copy link
Member

ararslan commented Nov 4, 2021

Hard to tell because Monterey infuriatingly gets in the way of using software. It just keeps telling me that "libopenlibm.3.0.dylib is damaged and can't be opened. You should move it to the Trash" and not letting me actually start Julia.

@staticfloat
Copy link
Member Author

Interesting; sounds like a codesigning issue. Ian verified that it worked on his Monterey machine, so I'm going to merge this. Alex, at your leisure, feel free to DM me on slack, and I'll try to figure out your codesigning problems.

@staticfloat staticfloat merged commit 486c8de into master Nov 4, 2021
@staticfloat staticfloat deleted the sf/loader_path_julia branch November 4, 2021 21:08
@ararslan ararslan added backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 4, 2021
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
Analogous to 236523f, we don't need to search in `@loader_path/julia` anymore, as `libjulia-internal` is now consistently within the same directory as our other dependencies.

(cherry picked from commit 486c8de)
KristofferC pushed a commit that referenced this pull request Nov 7, 2021
Analogous to 236523f, we don't need to search in `@loader_path/julia` anymore, as `libjulia-internal` is now consistently within the same directory as our other dependencies.

(cherry picked from commit 486c8de)
KristofferC pushed a commit that referenced this pull request Nov 11, 2021
Analogous to 236523f, we don't need to search in `@loader_path/julia` anymore, as `libjulia-internal` is now consistently within the same directory as our other dependencies.

(cherry picked from commit 486c8de)
KristofferC pushed a commit that referenced this pull request Nov 12, 2021
Analogous to 236523f, we don't need to search in `@loader_path/julia` anymore, as `libjulia-internal` is now consistently within the same directory as our other dependencies.

(cherry picked from commit 486c8de)
@KristofferC KristofferC removed backport 1.6 Change should be backported to release-1.6 backport 1.7 labels Nov 13, 2021
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
…2930)

Analogous to JuliaLang@236523f, we don't need to search in `@loader_path/julia` anymore, as `libjulia-internal` is now consistently within the same directory as our other dependencies.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
…2930)

Analogous to JuliaLang@236523f, we don't need to search in `@loader_path/julia` anymore, as `libjulia-internal` is now consistently within the same directory as our other dependencies.
staticfloat added a commit that referenced this pull request Dec 23, 2022
Analogous to 236523f, we don't need to search in `@loader_path/julia` anymore, as `libjulia-internal` is now consistently within the same directory as our other dependencies.

(cherry picked from commit 486c8de)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants