datatype: finish layout corrections #43306
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JeffBezanson
approved these changes
Dec 6, 2021
KristofferC
pushed a commit
that referenced
this pull request
Dec 7, 2021
We still had some discrepancies between what the code thought could be computed for a layout, and what we actually could compute layout for. This hopefully makes those two computations now always give the same answers (with the assistance of the layout cache). Fixes #43303 (cherry picked from commit 30fe8cc)
15 tasks
KristofferC
pushed a commit
that referenced
this pull request
Dec 11, 2021
We still had some discrepancies between what the code thought could be computed for a layout, and what we actually could compute layout for. This hopefully makes those two computations now always give the same answers (with the assistance of the layout cache). Fixes #43303 (cherry picked from commit 30fe8cc)
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Feb 22, 2022
We still had some discrepancies between what the code thought could be computed for a layout, and what we actually could compute layout for. This hopefully makes those two computations now always give the same answers (with the assistance of the layout cache). Fixes JuliaLang#43303
LilithHafner
pushed a commit
to LilithHafner/julia
that referenced
this pull request
Mar 8, 2022
We still had some discrepancies between what the code thought could be computed for a layout, and what we actually could compute layout for. This hopefully makes those two computations now always give the same answers (with the assistance of the layout cache). Fixes JuliaLang#43303
|
Might be the cause of this? #55076 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #43303