Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make BitSet field const #43553

Merged
merged 1 commit into from
Jan 5, 2022
Merged

Make BitSet field const #43553

merged 1 commit into from
Jan 5, 2022

Conversation

jakobnissen
Copy link
Contributor

Make the constant .bits field of BitSet const. See #43550

@jakobnissen jakobnissen mentioned this pull request Dec 26, 2021
Closed
16 tasks
@JeffBezanson JeffBezanson merged commit 98b485e into JuliaLang:master Jan 5, 2022
@N5N3
Copy link
Member

N5N3 commented Jan 6, 2022

Since some regression is link to new const feature. see #43561 (comment)
Should we block this (and similar PRs) until the regression is fixed?

N5N3 added a commit to N5N3/julia that referenced this pull request Jan 6, 2022
@N5N3
Revert "Allow const declarations on mutable fields (JuliaLang#43305)"
1ba44b1 
This reverts commit 63f6294.

Revert "Make BitSet field const (JuliaLang#43553)"

This reverts commit 98b485e.
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@jakobnissen @LilithHafner
Make BitSet field const (JuliaLang#43553)
ffadb7f
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@jakobnissen @LilithHafner
Make BitSet field const (JuliaLang#43553)
68ccf89
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jakobnissen @N5N3 @JeffBezanson