Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document use of / in LinearAlgebra #43632

Merged
merged 14 commits into from
Jan 20, 2022
Merged

Document use of / in LinearAlgebra #43632

merged 14 commits into from
Jan 20, 2022

Conversation

sasi591
Copy link
Contributor

@sasi591 sasi591 commented Jan 2, 2022 •
edited by DilumAluthge
Loading

Closes #43607

@dkarrasch dkarrasch changed the title Closes #43607 use of / in LinearAlgebra not documented Document use of / in LinearAlgebra Jan 2, 2022
@dkarrasch dkarrasch added docs This change adds or pertains to documentation linear algebra Linear algebra labels Jan 2, 2022
@ViralBShah @simonbyrne
Update stdlib/LinearAlgebra/src/generic.jl
e240e8d 
Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
@ViralBShah ViralBShah added the merge me PR is reviewed. Merge when all tests are passing label Jan 16, 2022
@DilumAluthge
Copy link
Member

Looks like an error during bootstrap.

@DilumAluthge DilumAluthge removed the merge me PR is reviewed. Merge when all tests are passing label Jan 17, 2022
@DilumAluthge
Copy link
Member

Also you need to fix the whitespace errors.

@sasi591
Copy link
Contributor Author

sasi591 commented Jan 18, 2022

Sorry for the delay, I have made all the changes, thank you. However, I don't understand why the builds are failing.

@simonbyrne simonbyrne merged commit 05d3e84 into JuliaLang:master Jan 20, 2022
@simonbyrne
Copy link
Contributor

Thanks!

@simeonschaub simeonschaub mentioned this pull request Feb 7, 2022
Open
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Feb 22, 2022
@sasi591 @ViralBShah
@simonbyrne @LilithHafner
Document use of / in LinearAlgebra (JuliaLang#43632)
3754049 
Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
LilithHafner pushed a commit to LilithHafner/julia that referenced this pull request Mar 8, 2022
@sasi591 @ViralBShah
@simonbyrne @LilithHafner
Document use of / in LinearAlgebra (JuliaLang#43632)
fbc7965 
Co-authored-by: Viral B. Shah <ViralBShah@users.noreply.github.com>
Co-authored-by: Simon Byrne <simonbyrne@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@simonbyrne simonbyrne simonbyrne left review comments

@simeonschaub simeonschaub Awaiting requested review from simeonschaub

Assignees
No one assigned
Labels
docs This change adds or pertains to documentation linear algebra Linear algebra
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use of / in LinearAlgebra not documented
5 participants
@sasi591 @DilumAluthge @simonbyrne @ViralBShah @dkarrasch